From 4820f82253b880c686471f68dbc0c69814d6c7b8 Mon Sep 17 00:00:00 2001
From: Marvin Flock <mflock@flock-it.de>
Date: Thu, 28 Aug 2025 21:16:34 +0200
Subject: [PATCH] chore: some review fixes

---
 .../views/sportsmanager/view_admin.php        | 20 +++++++++----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/structure/components/com_sportsmanager/views/sportsmanager/view_admin.php b/src/structure/components/com_sportsmanager/views/sportsmanager/view_admin.php
index 7d2ea7a..01b070a 100644
--- a/src/structure/components/com_sportsmanager/views/sportsmanager/view_admin.php
+++ b/src/structure/components/com_sportsmanager/views/sportsmanager/view_admin.php
@@ -8719,7 +8719,7 @@ class HTML_sportsmanager_admin
 				<a href="<?php echo SportsManagerURL('&task=admin_begegnungen_alle_entfernen&veranstaltungid=' . $veranstaltung->veranstaltung_id); ?>"
 				   onclick="return confirm('<?php echo Text::_('COM_SPORTSMANAGER_REMOVE_ALL_ENCOUNTERS'); ?>');"><?php echo Text::_('COM_SPORTSMANAGER_REMOVE_ALL_MATCHES'); ?></a>
 			</td>
-			<?php $Spalte_Nr = self::checkZeilenumbruch($Spalte_Nr, $max_Spalten); ?>
+			<?php self::checkZeilenumbruch($Spalte_Nr, $max_Spalten); ?>
 			<td nowrap>
 				<a href="<?php echo SportsManagerURL('&task=admin_begegnungen_export_form&veranstaltungid=' . $veranstaltung->veranstaltung_id); ?>"><?php echo Text::_('COM_SPORTSMANAGER_EXPORT'); ?></a>
 			</td>
@@ -8787,7 +8787,7 @@ class HTML_sportsmanager_admin
                                 if ($row->verlegung_eingetragen != null)
                                     echo " **";
                                 else if ($row->verlegt != 0)
-                                    echo " (" . formatTimediff($row->termin_original, $row->termin_akzeptiert, true) . ")";
+                                    echo " (" . self::formatTimediff($row->termin_original, $row->termin_akzeptiert, true) . ")";
                                 if ($row->nichtraucherschutz == 0 && ((($row->heim_nichtraucherschutz == 1 || $row->heim_nichtraucherschutz == 2 || $row->heim_nichtraucherschutz == 3) && ($row->gast_nichtraucherschutz == 3 || $row->gast_nichtraucherschutz == 7 || $row->gast_nichtraucherschutz == 8)) || (($row->heim_nichtraucherschutz == 5 || $row->heim_nichtraucherschutz == 6 || $row->heim_nichtraucherschutz == 8) && ($row->gast_nichtraucherschutz == 1 || $row->gast_nichtraucherschutz == 4 || $row->gast_nichtraucherschutz == 5))))
                                     echo " !";
                                 ?>
@@ -10206,11 +10206,11 @@ class HTML_sportsmanager_admin
 
         <form action="<?php echo SportsManagerURL(); ?>" method="post" name="adminForm" id="adminForm">
             <div class="uk-overflow-auto">
-                <table class="" style="width: 100%">
+                <table style="width: 100%">
                     <tr>
                         <td nowrap style="width: 60%; vertical-align: top">
                             <div class="uk-overflow-auto">
-                                <table class="" style="width: 100%">
+                                <table style="width: 100%">
                                     <tr>
                                         <td nowrap style="width: 20%; text-align: right">
                                             <label
@@ -10302,22 +10302,20 @@ class HTML_sportsmanager_admin
                                     </tr>
 									<tr>
 										<td nowrap style="width: 20%; text-align: right">
-											<?php echo Text::_('COM_SPORTSMANAGER_ROUND'); ?>
-											:
+                                            <label for="runde"><?php echo Text::_('COM_SPORTSMANAGER_ROUND'); ?>:</label>
 										</td>
 										<td nowrap>
 											<input class="uk-select uk-form-width-xsmall" style="height: 34px; text-align: left;"
-												name="runde" type="text" readonly value="<?php echo $veranstaltung->naechsteRunde; ?>"/>
+												name="runde" id="runde" type="text" readonly value="<?php echo $veranstaltung->naechsteRunde; ?>"/>
 										</td>
 									</tr>
 									<tr>
 										<td nowrap style="width: 20%; text-align: right">
-											<?php echo Text::_('COM_SPORTSMANAGER_ROUND_TITLE'); ?>
-											:
+                                            <label for="rundentitel"><?php echo Text::_('COM_SPORTSMANAGER_ROUND_TITLE'); ?>:</label>
 										</td>
 										<td nowrap>
 											<input list="auswahl_rundentitel" class="uk-select uk-form-width-large"
-												style="height: 34px; text-align: left;" type="text" name="rundentitel" size="32" maxlength="32"
+												style="height: 34px; text-align: left;" type="text" name="rundentitel" id="rundentitel" size="32" maxlength="32"
 												value="<?php echo $veranstaltung->titelVorschlag; ?>"/>
 											<datalist id="auswahl_rundentitel" >
 											<?php if ($auswahl_rundentitel){ ?>
@@ -10360,7 +10358,7 @@ class HTML_sportsmanager_admin
             <input type="hidden" name="veranstaltungid" value="<?php echo $veranstaltung->veranstaltung_id; ?>"/>
         </form>
         <?php
-		if ($sperren == true)
+		if ($sperren)
 			echo "<span style='display: inline-block; height: 30px; background: red; color: white;vertical-align: middle;'>
 			$Fehlertext</span>\n";
     }